Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow for setting the excludedPathsList key to an array of paths (strings) that can be appended to the urlExclusionsList property. #12

Merged
merged 2 commits into from
Oct 31, 2024
Merged

feat: Allow for setting the excludedPathsList key to an array of paths (strings) that can be appended to the urlExclusionsList property. #12

merged 2 commits into from
Oct 31, 2024

Conversation

ryangball
Copy link
Contributor

@ryangball ryangball commented Oct 30, 2024 •
edited by SMartorelli
Loading

…s (strings) that can be appended to the urlExclusionsList property.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.
Close #11

Pre-launch Checklist

  • [X ] I read the Code of Conduct and followed the process outlined there for submitting PRs.
  • [ X] I listed at least one issue that this PR fixes in the description above.
  • [X ] I updated/added relevant documentation (doc comments with ///).
  • [ X] I updated README.md file with new version/info - if applicable.
  • [NA ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • [NA] All existing and new tests are passing.

@ryangball ryangball force-pushed the allow-managed-exclusions branch from 2722d58 to 40e539d Compare October 30, 2024 16:12
SMartorelli
SMartorelli requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@SMartorelli SMartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR!
Please check the comment about urlExclusionList variable name.

migrator/AppContext.swift Outdated Show resolved Hide resolved
@SMartorelli SMartorelli added this to the Version 1.2.0 milestone Oct 31, 2024
@SMartorelli SMartorelli added the enhancement New feature or request label Oct 31, 2024
@ryangball
feat: Allow for setting the excludedPathsList key to an array of path…
c8092e0 
…s (strings) that can be appended to the urlExclusionsList property.

Signed-off-by: ryan-alectrona <ryan@alectrona.com>
@ryangball
fix: rename urlExclusionsList to urlExclusionList.
2e308f9 
Signed-off-by: ryan-alectrona <ryan@alectrona.com>
@ryangball ryangball force-pushed the allow-managed-exclusions branch from 76e635f to 2e308f9 Compare October 31, 2024 12:40
SMartorelli
SMartorelli approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@SMartorelli SMartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMartorelli SMartorelli linked an issue Oct 31, 2024 that may be closed by this pull request
[Feature Request] Allow for setting additional URLs to exclude via profile (UserDefaults) #11
Closed
@SMartorelli SMartorelli merged commit 078cbd1 into IBM:main Oct 31, 2024
3 checks passed
@ryangball ryangball deleted the allow-managed-exclusions branch November 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMartorelli SMartorelli SMartorelli approved these changes

Assignees

@ryangball ryangball

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 1.2.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow for setting additional URLs to exclude via profile (UserDefaults)
2 participants
@ryangball @SMartorelli