Skip to content

fix: escape % characters in DATABASE for Alembic config #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix: escape % characters in DATABASE for Alembic config #1534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mcpgateway/alembic/env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,11 @@ def _modify_metadata_for_mariadb():
# my_important_option = config.get_main_option("my_important_option")
# ... etc.

# Escape '%' characters in URL to avoid configparser interpolation errors
# (e.g., URL-encoded passwords like %40 for '@')
config.set_main_option(
"sqlalchemy.url",
settings.database_url,
settings.database_url.replace("%", "%%"),
)


Expand Down
5 changes: 4 additions & 1 deletion mcpgateway/bootstrap_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,10 @@ async def main() -> None:

with engine.begin() as conn:
cfg.attributes["connection"] = conn
cfg.set_main_option("sqlalchemy.url", settings.database_url)
# Escape '%' characters in URL to avoid configparser interpolation errors
# (e.g., URL-encoded passwords like %40 for '@')
escaped_url = settings.database_url.replace("%", "%%")
cfg.set_main_option("sqlalchemy.url", escaped_url)

insp = inspect(conn)

Expand Down
Loading