-
Notifications
You must be signed in to change notification settings - Fork 29
Implement dependency Inversion for runtime pkg - 1 #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: mayuka-c <Mayuka.C@ibm.com>
mkumatag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure we use the existing types instead of creating new ones
| Status string | ||
| } | ||
|
|
||
| type CreatePodResp struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please avoid adding these array kind of structure variables.
| RepoDigests []string | ||
| } | ||
|
|
||
| type PodInspect struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to use the already existing Pod type
| InfraContainerID string | ||
| } | ||
|
|
||
| type ContainerInspect struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let us see if we can use existing Container type
Sure I was in a dilemma myself too :) The main reason I added is because lets say as part of Create Pod Response, we might not be getting all the fields which we have defined in the @mkumatag Any suggestions? |
I feel like it's a maintenance headache. All these functions return almost the same thing, except for which fields are optional or mandatory. At the call site, we should just use strict checks if we are expecting specific fields, rather than returning a different type. |
Signed-off-by: mayuka-c <Mayuka.C@ibm.com>
Uh oh!
There was an error while loading. Please reload this page.