artifact link

[dafnapension]

closes: #1341

[elronbandel]

It looks good, just not sure, how to support the overwrite args.
Not sure how we could pass the arguments from the old artifact to the new one.
Lets say someone uses metrics.accurcay[lower_case=True] and metrics.accuracy points to its new name metrics.exact_match how can we pass the arguments [lower_case=True] to the new artifact ? (effectively resulting in metrics.exact_match[lower_case=True]) @yoavkatz @dafnapension what do you think?

[dafnapension]

Hi @elronbandel ,
As it is now, the new_artifact is a whole: an instantiated artifact. It is returned as is. Potentially, it does not have at all the fields specified in the overwrites of the original artifact referenced.
I think that a clear documentation can cover this issue.. :-)

[elronbandel]

The issue is old code with references to deprecated catalog names.
If someone has metrics.accurcay[lower_case=True] and we referred metrics.accurcay->metrics.exact_match his code wont work as before due to the arguments overwrite not being passed: [lower_case=True]

[yoavkatz]

In think deprecation and linking are distinct properties.

We can deprecate something without having a new link to it. So every artifact should have a deprecated field.

[dafnapension]

@yoavkatz , @elronbandel , I tried to address both your valuable comments. Please see.