Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified and thereby extended grouping, filtering, and splitting to control-comparison, over to global metrics and to bulk-instance metrics #845

Closed
wants to merge 6 commits into from

Conversation

dafnapension
Copy link
Collaborator

Suggest a scheme of "aggregator" to be similarly employed by all three types of MetricsWithConfidenceInterval.

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 90.78498% with 27 lines in your changes missing coverage. Please review.

Project coverage is 91.92%. Comparing base (a62c359) to head (b75c88e).
Report is 23 commits behind head on main.

Current head b75c88e differs from pull request most recent head 132d114

Please upload reports for the commit 132d114 to get more accurate results.

Files Patch % Lines
src/unitxt/metrics.py 90.28% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
+ Coverage   91.62%   91.92%   +0.29%     
==========================================
  Files         104      104              
  Lines       10996    10793     -203     
==========================================
- Hits        10075     9921     -154     
+ Misses        921      872      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafnapension dafnapension force-pushed the metrics_with_aggregators branch 2 times, most recently from 2c51503 to 044015f Compare May 19, 2024 12:21
@dafnapension dafnapension mentioned this pull request May 20, 2024
@dafnapension dafnapension force-pushed the metrics_with_aggregators branch 2 times, most recently from 79ff219 to 269ea31 Compare May 31, 2024 18:36
@dafnapension dafnapension changed the title Metrics with aggregators Extend grouping, filtering, and splitting to control-comparison, over to global metrics and to bulk-instance metrics Jun 2, 2024
@dafnapension dafnapension changed the title Extend grouping, filtering, and splitting to control-comparison, over to global metrics and to bulk-instance metrics Simplified and thereby extended grouping, filtering, and splitting to control-comparison, over to global metrics and to bulk-instance metrics Jun 2, 2024
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
…control-comparison splitting

Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
@dafnapension
Copy link
Collaborator Author

replaced by #890

@dafnapension dafnapension deleted the metrics_with_aggregators branch June 6, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant