Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(extension): Html Report Card Change, View menu and Filter addition #2024 #2027

Merged
merged 12 commits into from
Sep 12, 2024

Conversation

nam-singh
Copy link
Contributor

@nam-singh nam-singh commented Sep 5, 2024

  • Extension Update Feature

This PR is related to the following issue(s):

Testing reference:

  • View Menu( Element Roles, Requirement, Roles) in html report should work similar to extension
  • Filter (Violation, Needs review, Recommendations) should work as expected on clicking summary card/ filter menu

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@nam-singh nam-singh self-assigned this Sep 5, 2024
Copy link
Member

@tombrunet tombrunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just see the one thing on the code side.

common/module/src/report/ACReporterHTML.tsx Outdated Show resolved Hide resolved
@nam-singh
Copy link
Contributor Author

Just see the one thing on the code side.

Just see the one thing on the code side.

Got it, I did not noticed that build script is generating report in common module, I mistook it for broken import. Thank you for correcting

@nam-singh nam-singh closed this Sep 6, 2024
@nam-singh nam-singh reopened this Sep 6, 2024
@tombrunet
Copy link
Member

@ErickRenteria Please test

@nam-singh nam-singh changed the title feature(extension): Html Report Card Change, View menu and Filter addition #2019 feature(extension): Html Report Card Change, View menu and Filter addition #2024 Sep 9, 2024
@ErickRenteria ErickRenteria changed the base branch from master to htmlReportRelease September 11, 2024 16:18
@ErickRenteria
Copy link
Contributor

Validated

@ErickRenteria ErickRenteria merged commit 90da546 into htmlReportRelease Sep 12, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML Report Card Changes, and View and Filter menu changes
3 participants