Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(element_scrollable_tabbable, element_tabbable_role_valid): Fix issues related to scrollable and tabbable elements #2221

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Mar 7, 2025

  • Rule bug: element_scrollable_tabbable, element_tabbable_role_valid

This PR is related to the following issue(s):

Testing reference:

  • test case: test/v2/checker/accessibility/rules/element_scrollable_tabbable_ruleunit/scrollable_element_tabbable.html
    before the fix: an error reported on the first section element: "The tabbable element does not have a valid widget role".
    After the fix: the error goes away from the first section element. However, a different error is reported on the second and third section elements: "The tabbable element does not have a valid widget role".

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant