Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent ordering of RECURSIVE/CUDA bodies: CUDA first, recursive #103

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

abouteiller
Copy link
Contributor

Consistent ordering of RECURSIVE/CUDA bodies: CUDA first, recursive second.

This ordering is consistent with existing ordering in zgeqrf, and most kernels in zpotrf (except for po_po); this will prefer using GPU kernels if available, and fallback to recursive if load balancer lets a kernel fallback to CPU.

second

Signed-off-by: Aurelien Bouteiller <bouteill@icl.utk.edu>
@abouteiller abouteiller self-assigned this Oct 24, 2023
@abouteiller abouteiller requested a review from a team as a code owner October 24, 2023 18:45
@bosilca
Copy link
Contributor

bosilca commented Oct 24, 2023

This is not how we decided to fix this issue.

Copy link
Contributor

@bosilca bosilca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct fix should be in parsec and consist on creating a MCA parameter to define the order in which the BODYs are added to the incarnation arrays. However, this PR provides s consistent ordering in DPLASMA and improves the code readability.

@bosilca bosilca merged commit b69c8a6 into ICLDisco:master Oct 24, 2023
2 of 3 checks passed
@abouteiller abouteiller deleted the bugfix/reorder-recursive branch October 24, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants