-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HIP TRSM #122
Add HIP TRSM #122
Conversation
701267c
to
f06ece2
Compare
Some CUDA and HIP parameters are separate. Do we have a plan to make CUDA and HIP supported at the same time in the future? BTW, what I'm doing in HiCMA is adding a header file to redefine CUDA variables (at least for most of them) so that minimal change is needed. |
f06ece2
to
9aff551
Compare
Yes eventually that would be ideal. Right now it is not possible, but the code in dplasma is written in the way that would make it possible when parsec supports it.
We decided against doing a .h trickery because that almost works, but not always (rocsolver and cusolver do not always take the same parameters, in some cases you need a workspaces, but not in the other, etc.), and having a common code is therefore problematic and more error prone than helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI error is #115 and can be ignored |
This is based over #121 as this is needed for it to work
I have used the info handles in a different way than we did for potrf, I think its better than having to set taskpool internals in the wrapper