Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the proper PARSEC_HOOK_RETURN_ERROR in GPU error cases #99

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

abouteiller
Copy link
Contributor

Return the proper PARSEC_HOOK_RETURN_ERROR in GPU error cases

This is extracted from the HIP PR that I am currently squashing

@abouteiller abouteiller requested a review from a team as a code owner October 24, 2023 15:41
@abouteiller abouteiller self-assigned this Oct 24, 2023
Copy link
Contributor

@devreal devreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@therault therault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is a random error during the cleanup in the checks. This should be investigated, but I don't think it's due to this PR.

Signed-off-by: Aurelien Bouteiller <bouteill@icl.utk.edu>
@abouteiller abouteiller merged commit 94c442a into ICLDisco:master Oct 24, 2023
3 checks passed
@abouteiller abouteiller deleted the cleanup/cuda_check_error branch October 24, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants