Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable detection of AVX capabilities even if compiler would not generate vector code #653

Closed
wants to merge 1 commit into from

Conversation

abouteiller
Copy link
Contributor

Reenable detection of AVX capabilities even if compiler would not generate vectorized AVX code (because libraries like mkl can still use it). With the current status, the AVX availability on the CPU is never detected because we don't pass the necessary -march=xyz that enables AVX instruction generation.

@bosilca you made the opposite change some time ago, and I have vague recollection that there were issues with compiling the builtin checks without the ifdefs on some systems?

produce vectorized AVX code (because libraries like mkl can still use
it)
@abouteiller abouteiller added bug Something isn't working question Further information is requested labels May 17, 2024
@bosilca
Copy link
Contributor

bosilca commented May 17, 2024

The check for AVX512 was generating instructions that did not exists in some older architectures.

We can't assume what hardware capabilities the libraries we call can handle, this check should be related to what the runtime can handle.

@abouteiller
Copy link
Contributor Author

I see, that makes the builtin test pretty useless overall.

@abouteiller abouteiller deleted the bugfix/avx-detect branch May 22, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants