Fix the user-triggered termination test #664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
therault
commented
Jul 12, 2024
therault
commented
- Make sure the parsec context is started only after the taskpool is created as the taskpool will register active message handlers for the first time via the user-triggered option in PTG
- Correctly compute the number of local tasks instead of assuming a run at a given world size; compute that number on all ranks and check that all ranks have a correct value
- have all MPI rank return the same return code for consistency
- Free the taskpool when it's not used anymore to remove assertion.
- Make sure the parsec context is started only after the taskpool is created as the taskpool will register active message handlers for the first time via the user-triggered option in PTG - Correctly compute the number of local tasks instead of assuming a run at a given world size; compute that number on all ranks and check that all ranks have a correct value - have all MPI rank return the same return code for consistency - Free the taskpool when it's not used anymore to remove assertion.
devreal
approved these changes
Sep 6, 2024
|
This is breaking existing capabilities. The termination detection capability should work in all cases, not only when then context is started after the taskpool creation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.