Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show-caps: don't report flops for unknown cuda devs, report peer access #672

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abouteiller
Copy link
Contributor

@abouteiller abouteiller commented Sep 13, 2024

show-caps:

The diff looks bigger that what it actually is because I had to move the cuda show_caps to after all_devices_attached to be able to report peer-access, so its mostly copy pasting from cuda_module_init to all_devices_attached

  • undo the change that reorders the caps, after using this PR for a while the peer-access mask is not super relevant info

@abouteiller abouteiller requested a review from a team as a code owner September 13, 2024 04:30
@bosilca
Copy link
Contributor

bosilca commented Sep 13, 2024

Right, a whole lot of code move for a small benefit. I find it strange that we now query a device capabilities in parsec_cuda_all_devices_attached instead of the place where the device is actually initialized and made known to the runtime.

@abouteiller abouteiller marked this pull request as draft September 27, 2024 19:00
report simd cpu type if found
uniform output for show_caps
@abouteiller

This comment was marked as outdated.

@abouteiller abouteiller marked this pull request as ready for review October 2, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants