-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PETSc Tweaks #1235
Merged
Merged
PETSc Tweaks #1235
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c36be0b
start
43c691d
default dictionary
ae7a088
correct petsc snes solver call
f21c2f0
Iterate over only active blocks
0b1d52b
Merge branch 'main' into petsc-init-solver
97ebe63
get rid of artifact
d4619f5
symbolic solver labels
dallan-keylogic 888c67e
run Black
dallan-keylogic 54f4b6c
Merge branch 'main' into petsc-init-solver
lbianchi-lbl 5c96bc8
Merge branch 'main' into petsc-init-solver
dallan-keylogic c8fa0d6
test deprecation
dallan-keylogic 40b3269
Merge branch 'petsc-init-solver-new' into petsc-init-solver
dallan-keylogic 67235d5
better deprecation
dallan-keylogic 1ff3ba6
Merge branch 'main' into petsc-init-solver
andrewlee94 da0faa3
Merge branch 'main' into petsc-init-solver
dallan-keylogic 08cc910
Merge branch 'tmp' into petsc-init-solver
dallan-keylogic 69428ef
Merge branch 'main' into petsc-init-solver
dallan-keylogic edf1171
remove active flags due to bug in pyomo implementation
dallan-keylogic d34a302
Black wanted to go back to a single line
dallan-keylogic 51a4391
Merge branch 'main' into petsc-init-solver
dallan-keylogic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing as we are pushing to get backward compatibility tests into place, this look like a place where we are going to need backward compatibility options and warnings. I.e. we need to keep the old options around, and have them raise deprecation warnings if they are used before sending the value to the new argument (and raise an exception if both old and new are provided).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping that this feature being around for only a month and not making it into a major release would prevent that from being necessary. Perhaps not, however.
Edit:
snes_solver
has been around only for a month. However,snes_options
has been around longer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is that new then we are probably OK, but we need to double check that is the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got the deprecation logged for
snes_options
. Ready for a new review.