Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding deprecation warning for has_phase_equilibrium but only 1 phase #1236

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

andrewlee94
Copy link
Member

Required for #1225

Summary/Motivation:

This PR adds a deprecation warning for backward compatibility for cases where a control volume is set to include phase equilibrium terms but the associated property package only has a single phase.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@andrewlee94 andrewlee94 self-assigned this Aug 3, 2023
@andrewlee94 andrewlee94 added Priority:High High Priority Issue or PR core Issues dealing with core modeling components backward-compat Affects backward compatibility labels Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 88.23% and project coverage change: -0.01% ⚠️

Comparison is base (68e2c4f) 76.84% compared to head (e08105b) 76.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
- Coverage   76.84%   76.84%   -0.01%     
==========================================
  Files         390      390              
  Lines       61918    61924       +6     
  Branches    11400    11400              
==========================================
+ Hits        47580    47583       +3     
- Misses      11871    11875       +4     
+ Partials     2467     2466       -1     
Files Changed Coverage Δ
idaes/core/base/control_volume0d.py 89.38% <77.77%> (+0.04%) ⬆️
idaes/core/base/control_volume1d.py 90.21% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) August 3, 2023 22:33
@lbianchi-lbl lbianchi-lbl merged commit 0d253d3 into IDAES:main Aug 3, 2023
43 checks passed
@andrewlee94 andrewlee94 deleted the bc_issues branch August 4, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward-compat Affects backward compatibility core Issues dealing with core modeling components Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants