Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support calcuation of critical properties of mixtures in Modular Properties #1336
Support calcuation of critical properties of mixtures in Modular Properties #1336
Changes from 14 commits
819453a
9e3e098
027ad83
4af1dda
d795063
59525d6
9d06c2e
a7a0e92
ea8ff6e
692abbb
66db51f
46253e3
16520bd
7bdff70
c1a1f75
c4fff4f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to one day rename this "acentric factor", but that can wait for another day.
Check warning on line 272 in idaes/core/base/property_meta.py
Codecov / codecov/patch
idaes/core/base/property_meta.py#L270-L272
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good example of the perils of inconsistent data. We say Z_crit = 1, but P_crit/(rho_mol_critRT_crit) ~= 0.4376. It probably doesn't matter for this test, though.