PETSc DAE Index Reduction Fix #1670
Draft
+45
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
@blnicho says she should have time to look at this by early next week. |
…vated_disc_eqn_fix
adam-a-a
reviewed
Feb 6, 2026
Comment on lines
+619
to
+620
| # TODO does moving this outside the context manager | ||
| # have any unexpected side effects? |
Contributor
There was a problem hiding this comment.
@blnicho would you happen to know of any potential side effects?
adam-a-a
reviewed
Feb 6, 2026
| const_names.append(model.name + "." + s + "_pressure_balance") | ||
| const_names.append(model.name + "." + s + "_side_stream_pressure_balance") | ||
|
|
||
| # const_names.append(model.name + "." + s + "_material_holdup_constraint") |
Contributor
There was a problem hiding this comment.
Suggested change
| # const_names.append(model.name + "." + s + "_material_holdup_constraint") |
adam-a-a
reviewed
Feb 6, 2026
| for stream in model.streams: | ||
| holdup_var = getattr(model, stream + "_material_holdup") | ||
| holdup_eqn = getattr(model, stream + "_material_holdup_constraint") | ||
| # calculate_variable_from_constraint(holdup_var, holdup_eqn) |
Contributor
There was a problem hiding this comment.
Suggested change
| # calculate_variable_from_constraint(holdup_var, holdup_eqn) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
This PR is intended to allow PETSc to be used in problems where the DAE index has been reduced by deactivating some discretization equations and adding additional constraints. Frequently in IDAES models, we end up having to deactivate the discretization equations for a specific index, e.g.,
m.fs.unit.control_volume.material_accumulation_disc_eq[:, "Liq", "H2O"].deactivate(). This PR adds checks about whether the discretization equations for that index are active, then adds aDerivativeVarto the set of initial conditions to be fixed only if it is active.It also contains a workaround for Pyomo/pyomo#3734 .
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: