-
Notifications
You must be signed in to change notification settings - Fork 294
Fix issue 1684: bad stream table formatting for flash #1719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix issue 1684: bad stream table formatting for flash #1719
Conversation
activated the test for assert stream table contents under class TestBTIdealModular, to fix issue IDAES#1684
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1719 +/- ##
==========================================
- Coverage 73.67% 73.67% -0.01%
==========================================
Files 398 398
Lines 65101 65097 -4
Branches 10951 10950 -1
==========================================
- Hits 47962 47958 -4
Misses 14632 14632
Partials 2507 2507 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bpaul4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of typos, otherwise looks good.
idaes/models/unit_models/flash.py
Outdated
| stream_attributes[n][k + " " + kname] = quant.m | ||
| stream_attributes["Units"][k + " " + kname] = quant.u | ||
| else: | ||
| # If not using idea separation, we can get outlet state directly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # If not using idea separation, we can get outlet state directly | |
| # If not using ideal separation, we can get outlet state directly |
| "Inlet": { | ||
| "flow_mol": pytest.approx( | ||
| 1.00, rel=1e-4 | ||
| ), # This is different from it's property package's (BT_idea) properties_out value of 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ), # This is different from it's property package's (BT_idea) properties_out value of 100 | |
| ), # This is different from its property package's (BT_ideal) properties_out value of 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated all the typos in new push
|
@Lingyan90, do you think you can get to this for the Feb (this month's) release? |
Yes, was distracted by other things. The review comments looks straight forward. will push the changes asap. and should be able to be ready for Feb release. |
Fixes
Fixed a issue that has bad stream table formatting for Flash with Modular Properties (#1684)
Summary/Motivation:
Changes proposed in this PR:
flash.pyunder ideal separation scenariotest_flash.pyLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: