Resubmitting pull request for new state definition FpTPxpc with testing #1723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nding the property
…se test. Uses a FeedFlash unit model rather than a state block to perform the test
…ant config properties dictionary and file
…nstraint' based on `has_phase_equilibrium` boolean. Also additional conditional in blocking the activiation of the `equilibrium_constraint` if `mole_frac_phase_comp` is a state variable
…changes to a future potential feature
…nges were not passing tests and the changes are not necessary for anything. Maybe a potential future feature
…nges were not passing tests and the changes are not necessary for anything. Maybe a potential future feature
…s-pse into tanner/FpTPxpc
tannerpolley
requested review from
agarciadiego and
dallan-keylogic
as code owners
tannerpolley
added
Priority:Normal
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1723 +/- ##
==========================================
+ Coverage 73.63% 73.67% +0.03%
==========================================
Files 394 395 +1
Lines 64980 65145 +165
Branches 10947 10969 +22
==========================================
+ Hits 47851 47993 +142
- Misses 14627 14642 +15
- Partials 2502 2510 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dallan-keylogic
approved these changes
Jan 22, 2026
Contributor
dallan-keylogic
left a comment
dallan-keylogic
left a comment
There was a problem hiding this comment.
Just a few minor comments.
Comment on lines
+1536
to
+1559
| # | ||
| # m = model.fs.state[0] | ||
| # | ||
| # m.display() | ||
| # # | ||
| # # for v in m.component_data_objects(Var, active=True): | ||
| # # print(f"{v.name}: value={v.value}, lb={v.lb}, ub={v.ub}") | ||
| # # | ||
| # # print() | ||
| # # | ||
| # # for c in m.component_data_objects(Constraint, active=True): | ||
| # # print(c.name, c.expr) | ||
| # | ||
| # # As the phase equilibrium constraints were not solved, we expect these to have a large residual | ||
| # large_res = large_residuals_set(model.fs.state[0]) | ||
| # print(large_res) | ||
| # assert len(large_res) == 4 | ||
| # for i in large_res: | ||
| # assert i.name in [ | ||
| # "fs.state[0.0].phase_fraction_constraint[Liq]", | ||
| # "fs.state[0.0].phase_fraction_constraint[Vap]", | ||
| # "fs.state[0.0].equilibrium_constraint[Vap,Liq,H2O]", | ||
| # "fs.state[0.0].equilibrium_constraint[Vap,Liq,CO2]", | ||
| # ] |
Contributor
There was a problem hiding this comment.
What's happening with this commented code?
Comment on lines
+351
to
+354
| print() | ||
| print(j) | ||
| print(value(m.fs.state[1].flow_mol_phase_comp_apparent["Liq", j])) | ||
| print(value(m.fs.state[1].flow_mol), value(m.fs.state[1].mole_frac_comp[j])) |
Contributor
There was a problem hiding this comment.
We shouldn't have print statements in the final test.
Contributor
|
@tannerpolley , could you get to this PR soon? |
Member
|
@tannerpolley (and/or @agarciadiego )will you be able to get to this for the Feb (this month's) release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New State Definition FpTPxpc which has
flow_mol_phaseandmole_frac_phase_compas the state definitions with required testing