Skip to content

Fix for pytorch 2.8 - Replace value.type() with value.scalar_type #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for pytorch 2.8 - Replace value.type() with value.scalar_type #415

wants to merge 1 commit into from

Conversation

@pftq
Copy link

@pftq pftq commented Jun 14, 2025

Fixes the below error for pytorch 2.8 (B200, RTX 5090, etc):

  Building wheel for groundingdino (setup.py) ... error
  error: subprocess-exited-with-error

@lprestini
Copy link

lprestini commented Jul 17, 2025

Bumped into the same issues:
To get it to work I also had to replace all value.type().is_cuda() to value.is_cuda()

@lprestini lprestini mentioned this pull request Jul 17, 2025
Open
@matthew-strong-ai
Copy link

matthew-strong-ai commented Sep 5, 2025

@rentainhe ping on this -- this small fix saved a LOT of pain for me -- let's get it merged!

MMDNaoya added a commit to MMDNaoya/myMaskDINO that referenced this pull request Nov 12, 2025
@MMDNaoya
Edit based on IDEA-Research/GroundingDINO#415.
76c0986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pftq @lprestini @matthew-strong-ai