Skip to content

Fix logical error in true negative calculation#447

Open
mhd-medfa wants to merge 1 commit intoIDEA-Research:mainfrom
Unified-Promptable-Panoptic-Mapping:main
Open

Fix logical error in true negative calculation#447
mhd-medfa wants to merge 1 commit intoIDEA-Research:mainfrom
Unified-Promptable-Panoptic-Mapping:main

Conversation

@mhd-medfa
Copy link
Copy Markdown
Contributor

Fix two copy-paste errors in APOPMeter that caused self.fn to never be incremented, silently corrupting any metrics derived from false negatives (recall, F1, miss rate, etc.):

  • update(): line 291 wrote to self.tn with the FP condition (pred==1, gt==0) instead of self.fn with the FN condition (pred==0, gt==1)
  • update_cm(): line 297 accumulated fn into self.tn instead of self.fn

Fix two copy-paste errors in APOPMeter that caused self.fn to never
be incremented, silently corrupting any metrics derived from false
negatives (recall, F1, miss rate, etc.):

- update(): line 291 wrote to self.tn with the FP condition (pred==1,
  gt==0) instead of self.fn with the FN condition (pred==0, gt==1)
- update_cm(): line 297 accumulated fn into self.tn instead of self.fn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant