Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] New look task_card #2573

Closed
ChrisMarsh82 opened this issue Dec 2, 2024 · 1 comment · Fixed by #2626
Closed

[FEATURE] New look task_card #2573

ChrisMarsh82 opened this issue Dec 2, 2024 · 1 comment · Fixed by #2626
Assignees
Labels
feature Work on app features/modules

Comments

@ChrisMarsh82
Copy link
Collaborator

What?
Add a variant of the task card to match Facilitator Mexico designs.
image

Note: must be greyed out once completed.

How?
The number on the left hand side should be an image and not another value to be passed. task_card already supports images so it would just be styling changes needed. This would also give authors more flexibility in the future.

@ChrisMarsh82 ChrisMarsh82 added the feature Work on app features/modules label Dec 2, 2024
@jfmcquade
Copy link
Collaborator

@FaithDaka This should be achievable as a variant of the task-card component. I'm not sure what the best name for the variant would be, maybe something like block-button/button-block?

There's quite a lot of logic in the task card component that you can ignore, the button variant is probably the one to build from as this strips out a lot of the other elements. You can handle the two colour states by reading the existing progressStatus property, and checking whether it is "completed" (this is already added as a class on some of the child elements within the component, for example).

@FaithDaka FaithDaka linked a pull request Dec 15, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants