-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facilitator_mx Theme: New look task-card #2626
Conversation
@jfmcquade I made changes to the |
This was already included (see https://github.com/IDEMSInternational/app-debug-content/blob/main/config.ts), but I don't think you will have been shown how to update the deployment content (including config file) to reflect the main content branch. I've also given you write permissions on the debug repo, your invite is pending acceptance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The styling looks good. See my inline comments, including a blocking one about replacing the current plh_facilitator_mx
theme.
I also think that in the component demo template, as the block button variant is included as an example, it should be made clear that the variant is only styled for the plh_facilitator_mx
theme, e.g. in the title above the variant demo.
@ChrisMarsh82 I think this needs some changes before it can be merged, but the core styling/functionality should be there, so you could merge this feature branch into working branch. Note that @FaithDaka has set up an alternative plh_facilitator_mx
theme at src/theme/themes/plh_facilitator_mx/_index.scss
, where she's applied the same changes of the primary/secondary source theme colours as you did.
src/app/shared/components/template/components/task-card/task-card.component.html
Outdated
Show resolved
Hide resolved
…pp-builder into feature-new-look-task_card
After discussion with @ChrisMarsh82 we agreed that it makes sense to overwrite the pre-existing @ChrisMarsh82, could you give a quick functional check of this PR to make sure that the component is behaving as expected for you? @FaithDaka, I've cleaned up the code in the task card component template somewhat, essentially in your refactoring to use the modern Angular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisMarsh82 are you happy for this to be merged? I think you've been working from this feature branch anyway
PR Checklist
Description
block-button
for the task card. Task Cardplh-facilitator-mx
themeGit Issues
Closes #2573
Screenshots
inProgress
vsnotStarted