Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Remove support for row-level "disabled" property in favour of component param #2761

Open
jfmcquade opened this issue Jan 30, 2025 · 0 comments
Labels
feature Work on app features/modules

Comments

@jfmcquade
Copy link
Collaborator

jfmcquade commented Jan 30, 2025

What?
Following on from #2757, it was agreed that the row-level "disabled" property, which is not currently used, should be deprecated in favour of a component-level disabled param.

Why?
Having a row-level property (represented by a column in a template sheet) implies that the property has a meaning for all (or many) row types. For a property like disabled, which must be handled by components on a case-by-case basis, this property belongs in the parameter list. Additionally, having a disabled column alongside condition and hidden is confusing.

How?
See list of components that currently consume the row.disabled property. These should be refactored to expose a disabled parameter:

Image

The only example of an authored row.disabled property within the debug deployment sheets is in example_workshops_accordion.

@jfmcquade jfmcquade added the feature Work on app features/modules label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules
Projects
None yet
Development

No branches or pull requests

1 participant