-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make 'disabled' parameter of button component dynamic #2757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always happy to move towards more signal calls, although could you just check the one inline comment to clarify some expected behaviour?
src/app/shared/components/template/components/button/button.component.ts
Outdated
Show resolved
Hide resolved
@chrismclarke – Following our discussion, I've updated this PR to remove support within the button component for the row-level @esmeetewinkel this PR is ready for functional testing. |
Apologies @jfmcquade - I actually made a refactoring PR targetting this but forgot to tag you for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test on refactor branch instead
…bled-dynamic Refactor: button disabled dynamic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging as these changes have been tested on #2760
PR Checklist
Description
Enables the button component’s disabled/enabled state to dynamically reflect updates to the
disabled
parameter.Additionally, this PR removes support within the button component for the row-level
disabled
property, which is considered deprecated. See follow-up #2761 to roll out this change to other components.Dev notes
As we've discussed previously (for example, this comment thread on #2493), it would make sense to embrace angular signals more fundamentally in how we handle component parameters. This PR doesn't make any progress towards achieving this more generally, but ultimately it would likely make sense for all our authorable parameters to be parsed to computed/signal values that react to updates.
Git Issues
Closes #
Screenshots/Videos
Updated comp_button:
button.disabled.mov