Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make 'disabled' parameter of button component dynamic #2757

Merged
merged 9 commits into from
Jan 31, 2025

Conversation

jfmcquade
Copy link
Collaborator

@jfmcquade jfmcquade commented Jan 28, 2025

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

Enables the button component’s disabled/enabled state to dynamically reflect updates to the disabled parameter.

Additionally, this PR removes support within the button component for the row-level disabled property, which is considered deprecated. See follow-up #2761 to roll out this change to other components.

Dev notes

As we've discussed previously (for example, this comment thread on #2493), it would make sense to embrace angular signals more fundamentally in how we handle component parameters. This PR doesn't make any progress towards achieving this more generally, but ultimately it would likely make sense for all our authorable parameters to be parsed to computed/signal values that react to updates.

Git Issues

Closes #

Screenshots/Videos

Updated comp_button:

Screenshot 2025-01-28 at 12 37 24
button.disabled.mov

Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always happy to move towards more signal calls, although could you just check the one inline comment to clarify some expected behaviour?

@jfmcquade
Copy link
Collaborator Author

@chrismclarke – Following our discussion, I've updated this PR to remove support within the button component for the row-level disabled property. I've added #2761 as a follow-up, to refactor other components to use a disabled component param as opposed to the row-level property.

@esmeetewinkel this PR is ready for functional testing.

@chrismclarke
Copy link
Member

Apologies @jfmcquade - I actually made a refactoring PR targetting this but forgot to tag you for review
It's #2760 if you have a chance to look

Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test on refactor branch instead

Copy link
Collaborator Author

@jfmcquade jfmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as these changes have been tested on #2760

@jfmcquade jfmcquade disabled auto-merge January 31, 2025 14:23
@jfmcquade jfmcquade merged commit 902a7cf into master Jan 31, 2025
6 checks passed
@jfmcquade jfmcquade deleted the feat/button-disabled-dynamic branch January 31, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants