Test: task service tests; minimal test infrastructure for other services #2197
Conversation
…dels; WIP test configuration for task service
| ) | ||
| ).toBe(true); | ||
| }); | ||
| it("completing the highlighted task causes the next highest priority task to be highlighted upon re-evaluation", async () => { |
There was a problem hiding this comment.
nit(non-blocking) - for future dev, would it make sense to automatically re-evaluate after setting completed?
| expect(previousHighlightedTaskGroup).toBe(MOCK_DATA.data_list[taskGroupsListName].rows[0].id); | ||
| expect(newHighlightedTaskGroup).toBe(MOCK_DATA.data_list[taskGroupsListName].rows[2].id); | ||
| }); | ||
| it("when all tasks are completed, the highlighted task group is set to ''", async () => { |
There was a problem hiding this comment.
nit(non-blocking) - again more on the dev side. Given that previous and next highlighted task groups can be undefined (e.g. when running method without any params), does assign '' provide any additional info? e.g. to we either check for ==='' or just use truthy/falsy checks? If the latter than can probably set as undefined and keep just the two potential states (truthy string or undefined)
There was a problem hiding this comment.
Thanks for adding all the tests and tidying up the code. I've run the tests locally and all looking good to me.
I've added a couple minor non-blocking comments (likely to feed into v2 proposals/plans), but very happy to merge here for now - will definitely make it a lot easier to continue to develop the feature in the future.
Also thanks for migrating the draft pr notes to a separate issue, makes a lot more sense having as an issue.
PR Checklist
Description
Follow-up to #2176
task_group_set_highlightedactionGit Issues
Closes #
Screenshots/Videos