Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dynamic data tests #2205

Merged
merged 27 commits into from
Feb 28, 2024
Merged

Fix/dynamic data tests #2205

merged 27 commits into from
Feb 28, 2024

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Feb 14, 2024

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

  • Fix issue where dynamic data service does not properly clear data when prompted to reset. I expect this is down to memory management and only really impacts testing environment, so small hack/workaround included just to check for rows post initial creation and delete accordingly.
  • Fix tests to include missing await for before hook flow reset
  • Add test for flow reset method
  • Code tidying for tests
  • Code tidying for some of the service collection creation methods

NOTE
Builds on #2157 so should merge after to see clean diffs
Code updates in 9990c5a

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 14, 2024
@esmeetewinkel esmeetewinkel merged commit 9493c8d into master Feb 28, 2024
6 checks passed
@esmeetewinkel esmeetewinkel deleted the fix/dynamic-data-tests branch February 28, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants