Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Migrating from using the cordova-res package to using the capacitor-assets package for asset generation #2362

Closed
wants to merge 12 commits into from

Conversation

kwAsant
Copy link
Collaborator

@kwAsant kwAsant commented Aug 12, 2024

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

  • The capacitor-assets library was added to package.json using yarn.
  • Added commands for generating splash images and icons within android.ts and android.workflow.ts for Android.
  • Added commands for generating splash images and icons within ios.ts and ios.workflow.ts for iOS
  • Due to the nature of the capacitor-assets package, splash image and icon generation can co-occur using new commands.

Git Issues

Closes #2072

Screenshots/Videos

Unfortunately, I cannot get it for the yarn commands (an issue with my machine that I intend to fix later). However, capacitor-assets commands should produce these outputs:

Android:
image
image
image

iOS:image

kwAsant added 12 commits July 19, 2024 23:05
chore: Updated  and  to use capacitor/assets.
➤ YN0002: │ @angular-eslint/schematics@npm:17.2.1 [d9650] doesn't provide eslint (pff8e2), requested by @angular-eslint/eslint-plugin
➤ YN0002: │ @angular-eslint/schematics@npm:17.2.1 [d9650] doesn't provide eslint (pfbf2b), requested by @angular-eslint/eslint-plugin-template
➤ YN0002: │ @angular-eslint/schematics@npm:17.2.1 [d9650] doesn't provide typescript (p54564), requested by @angular-eslint/eslint-plugin
➤ YN0002: │ @angular-eslint/schematics@npm:17.2.1 [d9650] doesn't provide typescript (pc9ce6), requested by @angular-eslint/eslint-plugin-template
➤ YN0002: │ @firebase/analytics-compat@npm:0.2.6 [d4482] doesn't provide @firebase/app (p6a848), requested by @firebase/analytics
➤ YN0002: │ @firebase/analytics-compat@npm:0.2.7 [7527e] doesn't provide @firebase/app (p42514), requested by @firebase/analytics
➤ YN0002: │ @firebase/app-check-compat@npm:0.3.7 [d4482] doesn't provide @firebase/app (pb41f4), requested by @firebase/app-check
➤ YN0002: │ @firebase/app-check-compat@npm:0.3.9 [7527e] doesn't provide @firebase/app (pf3c2b), requested by @firebase/app-check
➤ YN0002: │ @firebase/auth-compat@npm:0.4.2 [d4482] doesn't provide @firebase/app (p2715b), requested by @firebase/auth
➤ YN0002: │ @firebase/auth-compat@npm:0.4.2 [d4482] doesn't provide @firebase/app-types (p11876), requested by @firebase/auth-types
➤ YN0002: │ @firebase/auth-compat@npm:0.5.2 [7527e] doesn't provide @firebase/app (p093dc), requested by @firebase/auth
➤ YN0002: │ @firebase/auth-compat@npm:0.5.2 [7527e] doesn't provide @firebase/app-types (pc3f82), requested by @firebase/auth-types
➤ YN0002: │ @firebase/firestore-compat@npm:0.3.12 [d4482] doesn't provide @firebase/app (p9808a), requested by @firebase/firestore
➤ YN0002: │ @firebase/firestore-compat@npm:0.3.12 [d4482] doesn't provide @firebase/app-types (p2dbd0), requested by @firebase/firestore-types
➤ YN0002: │ @firebase/firestore-compat@npm:0.3.25 [7527e] doesn't provide @firebase/app (pdd913), requested by @firebase/firestore
➤ YN0002: │ @firebase/firestore-compat@npm:0.3.25 [7527e] doesn't provide @firebase/app-types (p0fada), requested by @firebase/firestore-types
➤ YN0002: │ @firebase/functions-compat@npm:0.3.5 [d4482] doesn't provide @firebase/app (pd29da), requested by @firebase/functions
➤ YN0002: │ @firebase/functions-compat@npm:0.3.7 [7527e] doesn't provide @firebase/app (p8ae4c), requested by @firebase/functions
➤ YN0002: │ @firebase/installations-compat@npm:0.2.4 [d4482] doesn't provide @firebase/app-types (p1aa5c), requested by @firebase/installations-types
➤ YN0002: │ @firebase/installations-compat@npm:0.2.5 [7527e] doesn't provide @firebase/app-types (pb3663), requested by @firebase/installations-types
➤ YN0002: │ @firebase/messaging-compat@npm:0.2.4 [d4482] doesn't provide @firebase/app (ped452), requested by @firebase/messaging
➤ YN0002: │ @firebase/messaging-compat@npm:0.2.6 [7527e] doesn't provide @firebase/app (pd95c3), requested by @firebase/messaging
➤ YN0002: │ @firebase/performance-compat@npm:0.2.4 [d4482] doesn't provide @firebase/app (pfdd03), requested by @firebase/performance
➤ YN0002: │ @firebase/performance-compat@npm:0.2.5 [7527e] doesn't provide @firebase/app (p0d89b), requested by @firebase/performance
➤ YN0002: │ @firebase/remote-config-compat@npm:0.2.4 [d4482] doesn't provide @firebase/app (pc8545), requested by @firebase/remote-config
➤ YN0002: │ @firebase/remote-config-compat@npm:0.2.5 [7527e] doesn't provide @firebase/app (p1f5e3), requested by @firebase/remote-config
➤ YN0002: │ @firebase/storage-compat@npm:0.3.2 [d4482] doesn't provide @firebase/app (p5696d), requested by @firebase/storage
➤ YN0002: │ @firebase/storage-compat@npm:0.3.2 [d4482] doesn't provide @firebase/app-types (p5a70f), requested by @firebase/storage-types
➤ YN0002: │ @firebase/storage-compat@npm:0.3.4 [7527e] doesn't provide @firebase/app (p33415), requested by @firebase/storage
➤ YN0002: │ @firebase/storage-compat@npm:0.3.4 [7527e] doesn't provide @firebase/app-types (p5122b), requested by @firebase/storage-types
➤ YN0060: │ @idemsInternational/rapidpro-excel@workspace:packages/@idemsInternational/rapidpro-excel provides mocha (p5b181) with version 9.2.2, which doesn't satisfy what ts-mocha requests
➤ YN0002: │ @nrwl/devkit@npm:17.2.8 doesn't provide nx (pd9563), requested by @nx/devkit
➤ YN0002: │ @tensorflow/tfjs@npm:3.21.0 doesn't provide seedrandom (p563bf), requested by @tensorflow/tfjs-data
➤ YN0002: │ @trapezedev/project@npm:7.0.10 doesn't provide @types/node (pdec2c), requested by ts-node
➤ YN0002: │ @trapezedev/project@npm:7.0.10 doesn't provide typescript (pa4bbf), requested by ts-node
➤ YN0002: │ actions@workspace:packages/actions doesn't provide @types/node (p3cf2f), requested by ts-node
➤ YN0002: │ actions@workspace:packages/actions doesn't provide typescript (p0ea70), requested by ts-node
➤ YN0002: │ api@workspace:packages/api doesn't provide @types/validator (pe4ec6), requested by sequelize-typescript
➤ YN0002: │ api@workspace:packages/api doesn't provide express (p88a91), requested by swagger-ui-express
➤ YN0002: │ api@workspace:packages/api doesn't provide webpack (p9a604), requested by ts-loader
➤ YN0002: │ cypress-image-snapshot@npm:4.0.1 [3d616] doesn't provide jest (p626ab), requested by jest-image-snapshot
➤ YN0002: │ dexie-sync@workspace:packages/dexie-sync doesn't provide @types/node (p4e36c), requested by ts-node
➤ YN0060: │ dexie-sync@workspace:packages/dexie-sync provides eslint (pf080e) with version 8.56.0, which doesn't satisfy what eslint-config-airbnb-base requests
➤ YN0060: │ dexie-sync@workspace:packages/dexie-sync provides eslint (p8063c) with version 8.56.0, which doesn't satisfy what eslint-config-airbnb requests
➤ YN0002: │ dexie-sync@workspace:packages/dexie-sync doesn't provide eslint-plugin-jsx-a11y (pa3711), requested by eslint-config-airbnb
➤ YN0002: │ dexie-sync@workspace:packages/dexie-sync doesn't provide eslint-plugin-react (pa2d98), requested by eslint-config-airbnb
➤ YN0002: │ dexie-sync@workspace:packages/dexie-sync doesn't provide eslint-plugin-react-hooks (p60750), requested by eslint-config-airbnb
➤ YN0002: │ dexie-sync@workspace:packages/dexie-sync doesn't provide typescript (pd5ba3), requested by ts-node
➤ YN0002: │ dexie-sync@workspace:packages/dexie-sync doesn't provide typescript (p02fb6), requested by ts-node-dev
➤ YN0002: │ dexie@npm:3.2.6 doesn't provide karma (p7a216), requested by karma-safari-launcher
➤ YN0060: │ frontend@workspace:. provides @angular/compiler (p27109) with version 17.2.2, which doesn't satisfy what codelyzer requests
➤ YN0060: │ frontend@workspace:. provides @angular/core (p5b8db) with version 17.2.2, which doesn't satisfy what codelyzer requests
➤ YN0060: │ frontend@workspace:. provides marked (p8b47b) with version 2.1.3, which doesn't satisfy what marked-smartypants-lite requests
➤ YN0060: │ frontend@workspace:. provides rxjs (p2ab2f) with version 7.8.1, which doesn't satisfy what @ionic-native/core requests
➤ YN0060: │ frontend@workspace:. provides rxjs (p92e7f) with version 7.8.1, which doesn't satisfy what @ionic-native/device requests
➤ YN0060: │ frontend@workspace:. provides rxjs (p1de2b) with version 7.8.1, which doesn't satisfy what @ionic-native/http requests
➤ YN0060: │ frontend@workspace:. provides rxjs (p5a844) with version 7.8.1, which doesn't satisfy what @ionic-native/media requests
➤ YN0060: │ frontend@workspace:. provides rxjs (p017df) with version 7.8.1, which doesn't satisfy what @ionic-native/status-bar requests
➤ YN0002: │ frontend@workspace:. doesn't provide tslint (p697d7), requested by codelyzer
➤ YN0002: │ scripts@workspace:packages/scripts doesn't provide @types/node (pc6d25), requested by ts-node
➤ YN0060: │ test-e2e@workspace:packages/test-e2e provides cypress (p6c2c3) with version 8.7.0, which doesn't satisfy what cypress-image-snapshot requests
➤ YN0002: │ ts-node-dev@npm:2.0.0 [63981] doesn't provide @types/node (ped870), requested by ts-node
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed in 1s 34ms
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 2s 17ms
➤ YN0000: ┌ Link step
➤ YN0000: │ ESM support for PnP uses the experimental loader API and is therefore experimental
➤ YN0000: └ Completed in 0s 553ms
➤ YN0000: Done with warnings in 3s 894ms
@kwAsant kwAsant requested a review from jfmcquade August 12, 2024 14:35
@kwAsant kwAsant changed the title Chore: Migrating from using the Cordova-res package to using the Capacitor-assets package for asset generation Chore: Migrating from using the cordova-res package to using the capacitor-assets package for asset generation Aug 13, 2024
@jfmcquade
Copy link
Collaborator

Closing in favour of #2364

@jfmcquade jfmcquade closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Migrate package used for generating Android assets cordova-res->@capacitor/assets
2 participants