-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove gdrive sync credentials #2556
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
(updating to also remove config scripts credentials) |
@jfmcquade - would be good to get this merged if we can as I can see Ian has already emailed out new credential instructions so would be good to have the readme updated and decrypt workflow removed |
jfmcquade
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense and looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
maintenance
Core updates, refactoring and code quality improvements
scripts
Work on backend scripts and devops
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
Following #2544
Author Notes
In order to sync content from google drive a special
credentials.json
file is required to authorize the platform to act on behalf of users. This file is sensitive so we had previously kept it encrypted in the repo, and provided users with aprivate.key
file used to decrypt (different from the deployment private keys), and instructed to runyarn scripts config decrypt
command.This PR completely removes the encrypted config (google service terms prohibits doing this), so now instead whenever onboarding a new developer they will need to be provided with the
credentials.json
file directly (instead of private key used to decrypt). This file will need to be re-shared any time the credentials are revoked and recreated (shouldn't be too often)Existing users should be able to continue syncing with their previously decrypted credentials (local copy remains), unless it's decided to replace these (would require notifying all developers)
Dev Notes
I don't think the dev credentials were ever actually in use (platform seems to default to credentials in the scripts/config workspace). Once merged should be able to safely remove the dev credentials from cloud console (believe its in the
plh-teens-app1
project). We may also want to consider rotating the other credentialsGit Issues
Closes #
Screenshots/Videos
Example - error message observed if credentials are not available
![image](https://private-user-images.githubusercontent.com/10515065/390081505-a75b8e74-927c-43f6-9ec0-dcfb6a433649.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNjU4NTUsIm5iZiI6MTczOTA2NTU1NSwicGF0aCI6Ii8xMDUxNTA2NS8zOTAwODE1MDUtYTc1YjhlNzQtOTI3Yy00M2Y2LTllYzAtZGNmYjZhNDMzNjQ5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDAxNDU1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM4YzI3MTNiZTA4MGY5OGJjODVkOTdhOWZhN2I0YTViZGZiMjIyOGI1OTc0ZTFiNzExMjJiZTMwNDU3YjgwOTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.VuG0hdgDn35FKdHYw98fkjcWQ4yu2uzb4G91T5UTzSA)