Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'curved' variant for progress-path component #2762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfmcquade
Copy link
Collaborator

@jfmcquade jfmcquade commented Jan 30, 2025

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

Includes minimal changes from #2669 to add a new variant for the progress_path component: curved.

Whilst #2669 was usurped by #2698 for meeting the specific use case (which includes updates to the task_card component as well as adding a new PLH-specific progress path component), the former PR did include a new variant that may as well be preserved – I think it is more attractive than the previous two variants and may be desirable in future.

Git Issues

Closes #2669

Screenshots/Videos

comp_progress_path:

Screenshot 2025-01-30 at 12 21 25

Copy link

Visit the preview URL for this PR (updated for commit d3f63e4):

https://plh-teens-app1--pr2762-feat-progress-path-c-bw979211.web.app

(expires Thu, 13 Feb 2025 12:56:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c0bab6b08dd290fbf002fd6e07987fa4b5fce1

Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test passed. Happy to merge without code review since the changes are limited to a single component file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules test - preview Create a preview deployment of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants