Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System - Add Wireless Set No38 radio and 12ft antenna #1323

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

System - Add Wireless Set No38 radio and 12ft antenna #1323

wants to merge 28 commits into from

Conversation

Spartan190
Copy link

@Spartan190 Spartan190 commented Apr 7, 2024 •
edited
Loading

When merged this pull request will:

  • add the Wireless Set No38 Radio
  • add the Wireless Set No38 Radio 12ft antenna
  • add the WS19 vehicle rack

Video: https://youtu.be/RMP1mhgx4UI
image-85
AntennaAndBag
AntennaConnect

@Spartan190
Add:
fde7218 
   - initial integration of WS38 based on PRC343
@Spartan190
Rename:
98c44cd 
   - renamed prc343_RadioDialogue to ws38_RadioDialogue

Add:
   - added dumy mode knob
   - added functionality to turn radio on and off
   - added updating of the knob when sending
@Spartan190
Fix:
46ddf12 
   - disbabled debugging
@Spartan190
Fix:
24622ba 
   - fixed modeknob button size and position

Add:
   - added starting of sending when on send mode
@Spartan190
Add:
a73d467 
   - adding setting of frequencies with the dial (WIP)
@Spartan190
Add:
d2b1c51 
   - added changing of frequencies
@Spartan190
Fix:
cdf0c8a 
   - fixed getting of function state

Remove:
   - removed updating of UI when transmitting (for now)
@Spartan190
Fix:
70e56b9 
   - fixed handling of UI update for sending
@Spartan190
Update:
a6422de 
   - updated visual images

Fix:
   - fixed position and size of dial button
   - fixed radio to be on by default
@Spartan190
Update:
a96d5ae 
   - updated mode knob for better visuals
@Spartan190
Add:
8336c44 
   - added custom antennas for the WS38
@Spartan190
Add:
a84fbe2 
   - added 12FT placable antenna
@Spartan190
Fix:
7770663 
   - fixed setting of frequencies
   - fixed the antenna gains
@Spartan190
Fix:
b3dd967 
   - fixed radio to be a pack radio
@Spartan190
Add:
3c1d86b 
   - added correct model for WS38
   - added correct antenna model
@Spartan190
Add:
d85ffdf 
   - added new sounds for starting and ending transmitting

Remove:
   - removed "beep"  when starting transmitting

Fix:
   - fixed display name
@Spartan190
Fix:
d54552b 
   - fixed masses of WS38 and 12ft antenna
   - fix start transmission sound
   - WS38 is off by default
@Spartan190
Add:
ccf13fd 
   - correct editor preview image
   - made the antenna carryable with ace

Fix:
   - fixed interaction location
@Spartan190
Add:
287f080 
   - added correct icon
@Spartan190
Add:
5c57a41 
   - added WS19 rack
   - added possibility to mount the WS38 to the WS19 rack
@Spartan190
Add:
cc5a523 
   - added Antenna bag icon
   - added Antenna bag model
@Spartan190
Refactor:
fe0f14a 
   - removed old files of WS38
   - replaced tabs with spaces
@jonpas jonpas added this to the 2.13.0 milestone Apr 7, 2024
@mrschick mrschick mentioned this pull request Apr 12, 2024
Open
8 tasks
@jonpas
Copy link
Member

jonpas commented Jun 13, 2024

Nice work! I will try to review this soon!

@jonpas jonpas requested a review from Mike-MF July 2, 2024 18:45
@Mike-MF
Copy link
Collaborator

Mike-MF commented Jul 3, 2024

Needs to be updated from master so I can test it.

@jonpas
Copy link
Member

jonpas commented Jul 3, 2024

@Spartan190 Please allow pushing to this branch, or update to master yourself.

@Spartan190 @Mike-MF
Update addons/sys_rack/ws19/__PREP__.sqf
0484776 
Thanks, the auto format of VSCode is weird for macros

Co-authored-by: Mike-MF <TyroneMF@hotmail.com>
@Spartan190
Copy link
Author

@Spartan190 Please allow pushing to this branch, or update to master yourself.

I have invited you and @Mike-MF as members.
If there is a better way to grant access, let me know. It's actually my first time working with a fork

@Spartan190
Copy link
Author

We have also been using this in some events and noticed that the range is not very good and also not really usable in areas with a lot of trees. But we are currently on it trying to get it fixed.

@jonpas
Copy link
Member

jonpas commented Jul 3, 2024

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

This is most ideal.

@Spartan190
Copy link
Author

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

This is most ideal.

Ok I just noticed I don't have access to change this in the PR.

@Spartan190
Copy link
Author

I updated the branch with latest main

Mike-MF
Mike-MF approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@Mike-MF Mike-MF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wrong that I could see.

@mrschick
Copy link
Contributor

mrschick commented Jul 4, 2024

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
This is most ideal.

Ok I just noticed I don't have access to change this in the PR.

Same old issue with organization PRs 😕

@jonpas
Copy link
Member

jonpas commented Dec 18, 2024

We have also been using this in some events and noticed that the range is not very good and also not really usable in areas with a lot of trees. But we are currently on it trying to get it fixed.

What was the last status on signal quality on this radio? Has anything been done to mitigate it?

@Spartan190
Copy link
Author

We have also been using this in some events and noticed that the range is not very good and also not really usable in areas with a lot of trees. But we are currently on it trying to get it fixed.

What was the last status on signal quality on this radio? Has anything been done to mitigate it?

We have been checking on it and have a version to test but we haven't been able to test it in the group yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mike-MF Mike-MF Mike-MF approved these changes

Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Spartan190 @jonpas @Mike-MF @mrschick