-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin - Add Mumble support #980
base: master
Are you sure you want to change the base?
Conversation
Mumble plugin: Base class refactoring.
Will **NOT** compile.
…s/acre2-mumble into feature/mumble_plugin
Rewrite auto-plugin copy
…s/acre2-mumble into feature/mumble_plugin
Fix/arma3 rpcs
Public Beta testingThe code as-is does seem to work as expected and therefore I think it is now time to get the build out to everyone interested in order for you to try it out yourselves. Mind yourself though: This really is only a beta test, so things might end up breaking/freezing. Requirements
Server configurationIf you are using a fresh (unconfigured) Mumble server for your tests, you will probably want to configure it a bit, before diving in. To that end, perform the following steps
Plugin installationUpon starting Arma with ACRE loaded, the plugin will (most likely) be installed automatically. Ideally you should make sure that you don't have Mumble open at this point in order to not accidentally block write-access to the necessary files by having them open in Mumble. The automatic installation may complain about missing access rights. Just click on Regardless of whether ACRE complained or not, it is advisable to check the plugin installation manually. For that, navigate to Using my Mumble serverYou can reach my Mumble server at
FeedbackI would love to get feedback from you. I think probably the best place at this point is the ACRE Slack channel which I am part of. The slack channel would also be the best place for asking questions about any kind of things related to this test (be it Mumble- or ACRE-related). Fingers crossed it (mostly) works out well 🤞 |
Is this still being beta tested? Would love to see this finally in acre2. |
Yes, current plan:
Just need to find time for it. |
"still" might be too strong of a word. As of today, I have received exactly 0 (zero) reports of anyone having tried this out 🤷 |
I've done a little bit of testing and have found the following issues.
Everything else seems to work so far but I will still need to test more. One issue unrealated to acre is one player could not connect to my mumble server or yours, they are on a edu network but my server logs show an attempted connection but says remote closed. |
The connection issues appears a bit odd to me... Maybe there was some kind of blocking involved that his network employed. But in that case I would have assumed that the connection wouldn't work at all (aka there is also no server log entry) 🤷 |
Co-authored-by: Drofseh <Drofseh@users.noreply.github.com>
Copy only to AppData and use installation to determine which architecture of plugin to copy (based on Program Files folder it is installed in). Add 32-bit support for copying a 64-bit extension. Only install the same plugin architecture as the Mumble installation (avoid warning in chat window). Cleanup registry reading in Mumble auto-copy code, as it is not reliable.
Plugin auto-copy will now only copy to 32-bit support for copying a 64-bit extension (or rather finding the architecture of installed Mumble) was also added. Tested configurations (with fresh Mumble installs of version
There are no official Portable installations for Mumble, so that was ignored, but it can still be done with the |
Is there a compiled 2.10 plugin available? |
See pinned items in ACE3 Discord |
I'll just leave a small checklist of things that as of now require investigation/fixing:
|
Has there been any additional progress on this? Will the plugin ever be implemented into steam workshop? |
Unfortunately not - I wasn't able to pin down the performance issue as it seemed related to some of ACRE's internal workings and I didn't have the motivation to figure everything in there out by myself (and ACRE core devs are busy with other projects and therefore didn't have time to help me out with this). |
When merged this pull request will:
a custom Mumble/Murmur version (coming soon)Mumble1.4.*
ts3
andmumble
)Some merge commit references are wrong due to different repository.