Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media upload capability #124

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add media upload capability #124

merged 1 commit into from
Feb 20, 2024

Conversation

anirudhprabhakaran3
Copy link
Member

@anirudhprabhakaran3 anirudhprabhakaran3 commented Feb 19, 2024

Description

Add media configurations to allow media uploads on Corpus

Dependencies

None

Type of Change

What types of changes does your code introduce?

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test it on production xD


Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

render bot commented Feb 19, 2024

Copy link

livecycle bot commented Feb 19, 2024

ieee-nitk

Your Livecycle playground is ready 🎉.

🔃 _Updating from fce1ba6 ➡️ dffa01b (view log)

Invite team members and start collaborating 💪

Check the box and click "invite" to invite collaborators

  • Nishant Nayak

invite

Members already invited
  • Anirudh Prabhakaran

Click here to invite the rest of your team.

Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ensure that none of the existing static assets (mainly society logos) are not broken with this change.

@anirudhprabhakaran3 anirudhprabhakaran3 merged commit 5542c1a into main Feb 20, 2024
1 of 2 checks passed
@anirudhprabhakaran3 anirudhprabhakaran3 deleted the allow_media_urls branch February 20, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants