[Draft] Add Events Module #169
Conversation
yukitya-1811
added
enhancement
yukitya-1811
requested review from
nishant-nayak,
anirudhprabhakaran3 and
imApoorva36
| 'poc', | ||
| 'created_at') | ||
|
|
||
| widgets = { |
There was a problem hiding this comment.
You don't need to define this so explicity, right? Django does take care of showing the appropriate widget for each field.
|
|
||
| class Volunteer(models.Model): | ||
| event = models.ForeignKey(Event, null=False, on_delete=models.CASCADE) | ||
| exec_member = models.OneToOneField(ExecutiveMember, null=False, on_delete=models.CASCADE) |
There was a problem hiding this comment.
One exec member can only be a volunteer once? 👀
There was a problem hiding this comment.
A ForeignKey would work better here maybe? An exec member can volunteer many times, but each volunteer instance is mapped to a single event
| event = models.OneToOneField(Event, null=False, on_delete=models.CASCADE) | ||
| item = models.CharField(null=False, max_length=255) | ||
| description = models.TextField() | ||
| cost = models.DecimalField(max_digits=12, decimal_places=2, null=False) | ||
| source = models.URLField() |
There was a problem hiding this comment.
This implies 1 event can have just one budget (which is alright)
But then that implies each event can have just one item (which is not).
Also, I don't think the budget should be in the events module. Should be part of treasury imo. cc @nishant-nayak for comments.
There was a problem hiding this comment.
True. As of now this isn't really going to be worked upon, since we're mainly focusing on just getting Events up and running
| from django.contrib import messages | ||
| # Create your views here. | ||
|
|
||
| def dashboard(request): |
There was a problem hiding this comment.
Decorate for permissions!
| event_form.save() | ||
| messages.success(request, ("New event created!")) | ||
| else: | ||
| print(event_form.errors) |
There was a problem hiding this comment.
Return proper errors
| def manage_event(request): | ||
| return render(request, "events/manage_event.html") | ||
|
|
||
| def report(request): | ||
| return render(request, "events/report.html") |
There was a problem hiding this comment.
I'm guessing because this a draft. You'll need to fix the logic of these.
Description
Add the basic model framework for the events module. This PR deals with only the backend logic for now, which includes -
Event,Budget,Volunteer, andReportFixes #167
Dependencies
List any dependencies that are required for this change.
Type of Change
What types of changes does your code introduce?
Put an
xin the boxes that applyHow Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.