Skip to content

Conversation

susilnem
Copy link
Member

Addresses

Changes

  • Add change in flash update pdf
  • Change image size

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

Remove None fields from email and pdf
@susilnem susilnem force-pushed the fix/flash-update-export branch 3 times, most recently from 0593704 to fcdd958 Compare November 29, 2024 05:30
@szabozoltan69
Copy link
Contributor

Is that "# Don't use this in production" comment valid?

@susilnem
Copy link
Member Author

Is that "# Don't use this in production" comment valid?

@szabozoltan69
In production and staging it should point to the FullURL.
But for local it's hard to debug.

We are using hard-coded values for http and https in most cases. We need to refactor this.

@susilnem susilnem force-pushed the fix/flash-update-export branch 2 times, most recently from 0754607 to 424f3ad Compare November 29, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants