Skip to content

View mode in all DREF forms #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

View mode in all DREF forms #2015

merged 1 commit into from
Oct 7, 2025

Conversation

shreeyash07
Copy link
Collaborator

Summary

view mode in all dref forms and use finalize api in dref table

Addresses

  • Issue(s):

Depends On

Changes

  • Add view mode in all dref forms in language mismatch
  • use finalize api in dref table

This PR Ensures:

  • No typos or grammatical errors
  • No conflict markers left in the code
  • No unwanted comments, temporary files, or auto-generated files
  • No inclusion of secret keys or sensitive data
  • No console.log statements meant for debugging
  • All CI checks have passed

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0159c59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shreeyash07 shreeyash07 force-pushed the feature/readOnly-dref-forms branch from 46506d2 to a7697fd Compare September 25, 2025 06:55
@shreeyash07 shreeyash07 force-pushed the feature/dref-translations branch 2 times, most recently from 3760698 to eb36b71 Compare September 26, 2025 05:18
@shreeyash07 shreeyash07 force-pushed the feature/readOnly-dref-forms branch 2 times, most recently from 3ba7319 to 7629847 Compare September 26, 2025 05:35
@shreeyash07 shreeyash07 force-pushed the feature/readOnly-dref-forms branch from 7629847 to 814ac9a Compare September 26, 2025 05:50
@shreeyash07 shreeyash07 marked this pull request as ready for review September 26, 2025 05:55
AdityaKhatri
AdityaKhatri approved these changes Oct 7, 2025
View reviewed changes
app/src/views/AccountMyFormsDref/DrefTableActions/i18n.json Outdated
"dropdownActionEditLabel": "Edit",
"drefApprovalSuccessTitle": "Successfully approved the DREF!",
"drefApprovalFailureTitle": "Failed to approve the DREF!",
"drefFinalizeSuccessTitle": "Successfully finalize the DREF!",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"drefFinalizeSuccessTitle": "Successfully finalize the DREF!",
"drefFinalizeSuccessTitle": "Successfully finalized the DREF!",

app/src/views/AccountMyFormsDref/DrefTableActions/index.tsx
} else if (applicationType === 'FINAL_REPORT') {
finalizeFinalReport(null);
} else {
applicationType satisfies never;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?
Also, lets add a alert saying failed to finalize if none of the types match.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is handled in useRequest

app/src/views/AccountMyFormsDref/DrefTableActions/index.tsx
)}
>
{status === DREF_STATUS_DRAFT && applicationType === 'DREF' && (
{(status === DREF_STATUS_DRAFT || status === DREF_STATUS_FINALIZED) && applicationType === 'DREF' && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the person edit after its finalized?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@AdityaKhatri AdityaKhatri force-pushed the feature/readOnly-dref-forms branch from ea329ed to 0159c59 Compare October 7, 2025 05:10
@AdityaKhatri AdityaKhatri merged commit 7a2923b into feature/dref-translations Oct 7, 2025
4 checks passed
@AdityaKhatri AdityaKhatri deleted the feature/readOnly-dref-forms branch October 7, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnagorra tnagorra tnagorra approved these changes

@AdityaKhatri AdityaKhatri AdityaKhatri approved these changes

@frozenhelium frozenhelium Awaiting requested review from frozenhelium

@barshathakuri barshathakuri Awaiting requested review from barshathakuri

Assignees

@frozenhelium frozenhelium

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shreeyash07 @tnagorra @AdityaKhatri @frozenhelium