Z on Virtual points #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdupaysign
force-pushed
the
virtual_point
branch
from
467bb38
to
eb89910
Compare
leavauchier
requested changes
Jun 11, 2024
leavauchier
requested changes
Jul 15, 2024
|
|
||
| Parameters: | ||
| - points (numpy.ndarray): An array of 3D points [x, y, z] | ||
| - q (int): Percentage or sequence of percentages for the percentiles to compute. |
There was a problem hiding this comment.
Comme tu ne testes qu'avec une seule valeur de q dans l'appel de fonction, je pense que tu peux changer ton commentaire pour ne plus parler de séquence de pourcentages (sinon ça implique d'adapter le reste de ton code pour que ça marche aussi) :
Suggested change
| - q (int): Percentage or sequence of percentages for the percentiles to compute. | |
| - q (int): Percentage for the percentiles to compute. |
leavauchier
requested changes
Jul 16, 2024
test/pointcloud/test_crop_las.py
Outdated
| @@ -19,7 +19,7 @@ def setup_module(module): | |||
|
|
|||
|
|
|||
| def test_crop_pointcloud_default(): | |||
| classes = "[1:2]" | |||
| classes = [2] | |||
There was a problem hiding this comment.
normalement l'équivalent de ce que tu avais avant serait classes = [1, 2]
There was a problem hiding this comment.
c'est vrai, j'ai pas été rigoureuse !
|
Ca y est ! J'ai tout modifier ! On va pouvoir merger (jespère et donc créer une nouvelle branche pour les points virtuels)" |
leavauchier
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Création de la fonction qui calcule un Z le long du squelette hydro
/ ! \ 1er étape, car il faut une deuxième étape de lissage du Z