Skeleton #9
Closed
Skeleton #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed the double "save and remove lines" keep the best candidates for extremities
skeleton lines to points on mask used to closed gaps
create and keep lines to points on mask used to close gaps
leavauchier
requested changes
Jul 3, 2024
Co-authored-by: leavauchier <120112647+leavauchier@users.noreply.github.com>
Co-authored-by: leavauchier <120112647+leavauchier@users.noreply.github.com>
Modify parameters "dilatation_size" to "dilation_size" in this function
Co-authored-by: leavauchier <120112647+leavauchier@users.noreply.github.com>
leavauchier
requested changes
Aug 8, 2024
manually solved
to have valid polygons right at the start Fix the test to have the skeleton lines output
business being here
wrongly merged
leavauchier
requested changes
Aug 14, 2024
| import pandas as pd | ||
| from shapely.geometry import Point | ||
|
|
||
| sys.path.append('../lidro') |
test_close_holes_default that shouldn't be here
leavauchier
requested changes
Aug 19, 2024
| import pandas as pd | ||
| from shapely.geometry import Point | ||
|
|
||
| sys.path.append('../lidro') |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
python [modulefilename] and not only with python -m [modulefilename]
io.skeleton in configs_lidro.yaml
leavauchier
approved these changes
Aug 21, 2024
mdupaysign
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First "clean" push, with working code and tests, for review