Add gh-action to create a release on v*.*.* tags #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leavauchier
force-pushed
the
auto-release
branch
from
d2adaf7
to
309822a
Compare
alavenant
approved these changes
Jun 25, 2024
gliegard
reviewed
Jun 25, 2024
|
|
||
|
|
||
| def test_main(): | ||
| ini_las = "test/data/4_6.las" | ||
| dsm_dimension = "dsm_marker" | ||
| dtm_dimension = "dtm_marker" | ||
| with tempfile.NamedTemporaryFile(suffix="_mark_points_output.las") as las_output: | ||
| main(ini_las, las_output.name, dsm_dimension, dtm_dimension, "", "") | ||
| mark_points_to_use_for_digital_models_with_new_dimension( | ||
| ini_las, las_output.name, dsm_dimension, dtm_dimension, "", "" |
There was a problem hiding this comment.
niveau lecture, on sait pas trop à quoi ça correspond "", ""
ce serait plus lisible avec les noms des parametres
output_dsm=""
output_dtm=""
| @@ -1,13 +1,19 @@ | |||
| [project] | |||
| name = "pdal_ign_macro" | |||
| dynamic = ["version"] | |||
| readme = "README.md" | |||
| description = "Macros and pipelines for Pdal based on the https://github.com/IGNF/pdal-ign-plugin plugin" | |||
There was a problem hiding this comment.
Comme c'est la description du package python, j'aurai mis un truc qui fait la difference entre le python et le c++, comme ça :
"Python examples to use C++ PDAL plugin https://github.com/IGNF/pdal-ign-plugin"
Enfin c'est qu'une suggestion, c'est comme tu préfères.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create github release