feat:add faq and quickguide #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrstark14
requested changes
Aug 30, 2023
models/faq.py
Outdated
| from formula_one.models.base import Model | ||
| from formula_one.utils.upload_to import UploadTo | ||
|
|
||
| class faq(models.Model): |
There was a problem hiding this comment.
follow proper naming convention with first character in upper case
models/faq.py
Outdated
| ) | ||
|
|
||
| class Meta(object): | ||
| verbose_name_plural='faqs' |
models/quickguide.py
Outdated
| from formula_one.models.base import Model | ||
| from formula_one.utils.upload_to import UploadTo | ||
|
|
||
| class quickguide(models.Model): |
models/quickguide.py
Outdated
| upload_to=UploadTo('helpcentre','quickguide'), | ||
| blank=False, | ||
| null=False, | ||
| ) |
serializers/faq_serializer.py
Outdated
| from rest_framework.serializers import ModelSerializer | ||
| from helpcentre.models import faq | ||
|
|
||
| class faq_serializer(ModelSerializer): |
serializers/quickguide_serializer.py
Outdated
| from rest_framework.serializers import ModelSerializer | ||
| from helpcentre.models import quickguide | ||
|
|
||
| class quickguide_serializer(ModelSerializer): |
There was a problem hiding this comment.
https://peps.python.org/pep-0008/#class-names
name convention should be done according to this
views/faq_view.py
Outdated
| Person=swapper.load_model('kernel','Person') | ||
| Maintainer=swapper.load_model('kernel','Maintainer') | ||
|
|
||
| class faq_view(ModelViewSet): |
| }, | ||
| status=status.HTTP_403_FORBIDDEN, | ||
| ) | ||
|
|
views/quickguide_view.py
Outdated
| 'Error':'You cannot perform this action' | ||
| }, | ||
| status=status.HTTP_403_FORBIDDEN, | ||
| ) |
views/quickguide_view.py
Outdated
| Person=swapper.load_model('kernel','Person') | ||
| Maintainer=swapper.load_model('kernel','Maintainer') | ||
|
|
||
| class quickguide_view(ModelViewSet): |
There was a problem hiding this comment.
follow proper naming conventions, read previous codes and then do naming
mrstark14
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.