Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installed simpa version in hdf5 files #325

Merged
merged 10 commits into from
Jul 29, 2024
Merged

Conversation

jnoelke
Copy link
Collaborator

@jnoelke jnoelke commented Jun 27, 2024

Please check the following before creating the pull request (PR):

  • Did you run automatic tests?
  • Did you run manual tests?
  • Is the code provided in the PR still backwards compatible to previous SIMPA versions?

Provide issue / feature request fixed by this PR
The simpa hdf5 files now contain the key simpa_version. The naming is described here .

Fixes #107

@jnoelke jnoelke marked this pull request as ready for review July 26, 2024 08:16
@jnoelke jnoelke requested a review from kdreher July 26, 2024 11:13
Copy link
Collaborator

@kdreher kdreher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kdreher kdreher merged commit fee92c7 into develop Jul 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants