review: fix: Correct wrong switch behaviours (#5730, #5731)#5732
Merged
monperrus merged 11 commits intoINRIA:masterfrom Feb 20, 2025
Merged
review: fix: Correct wrong switch behaviours (#5730, #5731)#5732monperrus merged 11 commits intoINRIA:masterfrom
monperrus merged 11 commits intoINRIA:masterfrom
Conversation
Mr-Pine
force-pushed
the
controlflow-switch-fixes
branch
from
3f8f75b to
af37cf6
Compare
As a side effect, fall throughs now go to the next block, not the next case expression
Mr-Pine
force-pushed
the
controlflow-switch-fixes
branch
from
af37cf6 to
13bde5c
Compare
Mr-Pine
changed the title
MartinWitt
reviewed
Apr 6, 2024
spoon-control-flow/src/main/java/fr/inria/controlflow/ControlFlowBuilder.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
This is now also covered by #5742 |
Collaborator
|
@Mr-Pine this is cool, how to complete it? |
Contributor
Author
|
@monperrus I've merged master into this branch and resolved the conflicts. From my side this can be merged. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds fixes for #5730 and #5731
As a side effect of the fix for #5731 fall through cases now connect to the statement block of the next case instead of the following case expression, which in my opinion makes more sense anyway.