You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that JDT with compliance level 25 parses FooCasper strangely. Maybe the 4 slash symbols at line 5 of FooCasper.java are confused with a javadoc markdown comment?
Anyway, since this is not the main focus of the PR, I guess that we can live with a regular // line comment on line 5.
The following patch makes LinesTest.testCompileWhenUsingLinesArgument pass.
--- a/src/test/java/spoon/test/prettyprinter/testclasses/FooCasper.java (revision f77e0ad8f92be6bbf9b667a32296209d0f1478a9)
+++ b/src/test/java/spoon/test/prettyprinter/testclasses/FooCasper.java (date 1774625574058)
@@ -2,7 +2,7 @@
public class FooCasper {
// public static void main(String[] args) {
-//// new FooCasper().selfTest();
+// new FooCasper().selfTest();
// }
FooCasper f;
It seems that JDT with compliance level 25 parses FooCasper strangely. Maybe the 4 slash symbols at line 5 of FooCasper.java are confused with a javadoc markdown comment?
Anyway, since this is not the main focus of the PR, I guess that we can live with a regular // line comment on line 5.
The following patch makes LinesTest.testCompileWhenUsingLinesArgument pass.
--- a/src/test/java/spoon/test/prettyprinter/testclasses/FooCasper.java (revision f77e0ad8f92be6bbf9b667a32296209d0f1478a9)
+++ b/src/test/java/spoon/test/prettyprinter/testclasses/FooCasper.java (date 1774625574058)
@@ -2,7 +2,7 @@
public class FooCasper {
// public static void main(String[] args) {
-//// new FooCasper().selfTest();
+// new FooCasper().selfTest();
// }
FooCasper f;
The problem is indeed that //// ...is a markdown comment, but we currently recognize it as a javadoc comment, and therefore print it incorrectly. @MartinWitt was looking into markdown comment support, depending on his progress it might make sense to just wait, otherwise we can adjust the test though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently not running tests using Java 25. Let's change that.