Fix variants not updating when switching scenario

INSM-TUM · Aug 28, 2024 · ed8351c · ed8351c
1 parent 592391c
commit ed8351c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/frontend/cypress/e2e/application.cy.js b/frontend/cypress/e2e/application.cy.js
@@ -554,5 +554,7 @@ describe('LCA Configuration Tests', () => {
             cy.get('button.chakra-accordion__button').should('have.length', 1);
             cy.get('button.chakra-accordion__button').findByText(newVariantName).should('exist');
         });
+
+        // TODO regression test for: View doesn't update when changing scenarios
     });
 });
diff --git a/frontend/src/components/Lca/Components/LcaVariantsConfiguration.jsx b/frontend/src/components/Lca/Components/LcaVariantsConfiguration.jsx
@@ -33,7 +33,7 @@ function LcaVariantsConfiguration({ getData, toasting }) {
 
     setVariants(lcaDm.getVariants(getData));
     setIsScenarioModelLoaded(true);
-  }, []);
+  }, [getData]);
 
   const handleSaveCostVariant = async (variant) => {
     const isExistingVariant = variant.id && variants.some(v => v.id === variant.id);