Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add publish CD job and allow for prerelease versions #4

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Lance-Drane
Copy link
Collaborator

Changes

  • The real version string is now represented by a variable called version_string, this allows for __version__ to contain prerelease information. Note that version_string and version_info will never contain build metadata or prerelease information.
  • Adds a CD job to publish to PyPI and also Github Releases. In the future we may want to require a CHANGELOG.md file be maintained, and we can create release information from that.

Signed-off-by: Lance Drane <dranelt@ornl.gov>
@Lance-Drane Lance-Drane self-assigned this Jun 7, 2024
Copy link
Collaborator

@marshallmcdonnell marshallmcdonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I guess do we test this via a pre-release?

.github/workflows/publish.yml Show resolved Hide resolved
@Lance-Drane
Copy link
Collaborator Author

Awesome! I guess do we test this via a pre-release?

We can, if you want. I think that would require me changing the version in the source code temporarily, then changing it back to a "release" version. I'll go ahead and merge this since it should only apply to tags.

@Lance-Drane Lance-Drane merged commit e054ba5 into main Jun 7, 2024
17 checks passed
@Lance-Drane Lance-Drane deleted the publishing-versioning branch June 24, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants