Add error handling for GitHub API job URL fetching in build-artifact workflow#185
Merged
printminion-co merged 2 commits intomk/dev/jfrog_add_workflow_infofrom Jan 15, 2026
Merged
Conversation
… workflow Co-authored-by: printminion-co <145785698+printminion-co@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enhance artifact upload process with richer metadata
Add error handling for GitHub API job URL fetching in build-artifact workflow
Jan 15, 2026
1266c74
into
mk/dev/jfrog_add_workflow_info
1 check failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses review feedback from PR #184 by adding robust error handling to GitHub API calls that fetch job URLs for JFrog artifact metadata. Previously, API failures or invalid responses would silently result in empty job URLs propagating to artifact properties.
Error handling added:
Affected locations:
build-external-appsjob (lines 309-330) - fetches URL for matrix build jobsPush to artifactoryjob (lines 722-743) - fetches URL for main artifact uploadBoth locations now use consistent error handling pattern:
TODO
Checklist
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.