Skip to content

IONOS(build): reduce code duplication and improve error handling in workflow#190

Merged
printminion-co merged 2 commits intomk/dev/jfrog_add_workflow_infofrom
copilot/sub-pr-184-again
Jan 16, 2026
Merged

IONOS(build): reduce code duplication and improve error handling in workflow#190
printminion-co merged 2 commits intomk/dev/jfrog_add_workflow_infofrom
copilot/sub-pr-184-again

Conversation

Copy link

Copilot AI commented Jan 16, 2026

Summary

Addresses code review feedback to eliminate repeated expressions, improve error handling, and enhance code maintainability in the build workflow.

Cache Version Computation:

  • Centralized repeated cache version expression (CACHE_VERSION + optional suffix) into a single computed output in prepare-matrix job
  • Eliminated duplication across 4 locations (lines 195, 307, 340, 1201) by referencing effective_cache_version output

Error Handling:

  • Added trap cleanup EXIT in get-job-data action to guarantee temporary file cleanup in all exit paths (success, error, early exit)

Code Quality:

  • Replaced xargs-based whitespace trimming with bash parameter expansion for better readability
  • Added explanatory comments for IFS array joining technique used in property string construction

TODO

  • ...

Checklist


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…mprove maintainability

Co-authored-by: printminion-co <145785698+printminion-co@users.noreply.github.com>
Copilot AI changed the title [WIP] Enhance artifact upload process in GitHub Actions IONOS(build): reduce code duplication and improve error handling in workflow Jan 16, 2026
Copilot AI requested a review from printminion-co January 16, 2026 15:54
@printminion-co printminion-co marked this pull request as ready for review January 16, 2026 15:57
@printminion-co printminion-co merged commit f72061d into mk/dev/jfrog_add_workflow_info Jan 16, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants