ci: fix pipelines on first run with apps-externa submodule change

[printminion-co]

Summary

This pull request refactors and simplifies the app restoration process in the build-artifact.yml GitHub Actions workflow. The main improvements include consolidating the app restoration logic into a single step, switching from artifact downloads to direct JFrog downloads for newly built apps, and expanding the conditions for uploading artifacts to Artifactory. These changes streamline the workflow, reduce complexity, and improve reliability.

App restoration process simplification:

• Consolidated the restoration of cached and newly built apps into a single script step, replacing multiple steps and artifact downloads with direct JFrog downloads for newly built apps. This removes the need for reorganizing downloaded artifacts and verifying their structure, making the process more efficient. [1] [2]
• The restoration logic now checks for both cached apps and newly built apps, downloading and extracting them directly from JFrog based on the matrix output.

Workflow condition improvements:

• Expanded the condition for uploading artifacts to Artifactory to include manual workflow_dispatch events, in addition to PRs and branch pushes. This allows for more flexible triggering of uploads.

Minor workflow adjustments:

• Removed the conditional setup of JFrog CLI, making it unconditional to ensure it's available for all restoration scenarios.

Test

• mannual triggered job https://github.com/IONOS-Productivity/ncw-server/actions/runs/21833117974
• Produces same artifact

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[Copilot]

Pull request overview

Fixes CI cache restoration so cached app tarballs don’t extract into pre-existing git submodule directories, preventing misplaced files during the first pipeline run.

Changes:

• Remove existing $APP_PATH directory before extracting/restoring cached app artifacts from JFrog cache.
• Remove existing $APP_PATH directory before restoring cached app artifacts from GitHub cache.

[printminion-co]

@copilot open a new pull request to apply changes based on the comments in this thread

[Copilot]

@printminion-co I've opened a new pull request, #230, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/build-artifact.yml:1

• Making JFrog CLI setup unconditional can break workflow runs where secrets.* are unavailable (notably pull_request runs from forks), because the action and subsequent jf rt ping will likely fail with empty credentials. Consider restoring a conditional guard (e.g., only run when has_apps_to_restore or has_apps_to_build is true), and/or gating on events where secrets are guaranteed to be present.

name: Build Nextcloud Workspace artifact (Optimized)