Revert "IONOS(appsettings): conditionally display developer documentation link based on configuration"#245
Open
Arsalanulhaq wants to merge 22 commits intoionos-devfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously added configuration-driven logic for conditionally showing the “Developer documentation” link in the app store navigation, removing the related backend initial-state and frontend UI usage.
Changes:
- Removed
display_documentation_linkhandling andappstoreDeveloperDocsinitial state fromAppSettingsController. - Removed the “Developer documentation” navigation item and its state consumption from
AppStoreNavigation.vue. - Removed tests that covered the conditional docs-link behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/settings/tests/Controller/AppSettingsControllerTest.php | Drops app-config mocking and removes docs-link assertions/tests; updates initial-state expectations. |
| apps/settings/src/views/AppStoreNavigation.vue | Removes developer docs nav entry and associated loadState usage. |
| apps/settings/lib/Controller/AppSettingsController.php | Removes app-config dependency and initial-state provision for developer docs URL. |
| IONOS | Updates the submodule SHA. |
Arsalanulhaq
force-pushed
the
rc/ncw-4
branch
from
978980a to
316d3e0
Compare
…he and JFrog Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
…atch for artifact uploads
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Misha M.-Kupriyanov <145785698+printminion-co@users.noreply.github.com>
… script to update Nextcloud user email) https://github.com/IONOS-Productivity/ncw-config/releases/tag/bacda90 Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
To update your local repo cd ncw-server rm -rf .git/modules/apps-external/activity git submodule deinit -f apps-external/activity git pull git submodule update --init --recursive apps-external/activity git submodule sync apps-external/activity Verify the change: cd apps-external/activity git remote -v Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
…r app in configuration and Makefile) https://github.com/IONOS-Productivity/ncw-config/releases/tag/bdfd74f Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Kai Henseler <kai.henseler@strato.de> Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de> Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de> Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
…tion link based on configuration" This reverts commit 8217b8a.
…ration" This reverts commit a79215c.
Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
…ild ncw core config" Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
Arsalanulhaq
force-pushed
the
as/dev/devDocs-link-removal-from-nextcloud
branch
from
3258d2b to
01f08b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request removes the configuration and UI logic related to conditionally displaying the developer documentation link in the app store navigation. The code and tests for toggling the visibility of the developer docs link based on the
display_documentation_linkconfig value have been eliminated, resulting in a simpler and more maintainable codebase.Commit reverts:
This reverts commit 8217b8a.
This reverts commit a79215c.
TODO
Checklist