Preprocessing #9
Conversation
| Run the the following once, since it will install the packages for | ||
| you: | ||
|
|
||
| > pkg install packages/* |
There was a problem hiding this comment.
These are Octave-specific packages? We run this on the Octave command line?
There was a problem hiding this comment.
These are octave-specific. I doubt they'll work on Matlab.
Just install them once on the command line and they'll stay installed. My driver has a line to ensure the image package is loaded.
There was a problem hiding this comment.
How long is this supposed to take? I think octave is hanging...
FYI for anyone else installing the packages, it takes several minutes with no feedback whatsoever.
|
Other than my comments, looks fine. |
|
Thanks. I fixed and am just testing the changes. Should have an update in a bit. Afterwards I'll test your pr. |
|
Fixed stuff. Tell me what you think. |
|
I can't say for sure, but this feature set might not give us good results. For example, look at the bottom-right example in Testing7.jpg, which is a Anyway, that's just a theory... I can't say anything for certain. |
| for k=1:min(numel(B), feature_count), | ||
| [features(k).width, features(k).height] = calcDim(B{k}); | ||
| features(k).x = min(B{k}(:,1)); | ||
| features(k).y = min(B{k}(:,2)); |
There was a problem hiding this comment.
I think this x and y are still reversed.
|
You're completely right for using it on it's own, but I assumed that we would be passing in the pixel matrix as well, like we did in the assignment. I'm in etlc if you'd like to discuss this. The current measured features are those that I rationalized being the most straight forward considering our limited implementation time. |
|
Ah, OK. |
|
Fixed that x/y problem. |
|
Looks good. |
| features(feature_count).x = []; | ||
|
|
||
| % 1. Threshold the image | ||
| img = rgb2gray(image); |
There was a problem hiding this comment.
using rgb2gray doesn't work on windows. Not sure why
|
It seems good. I don't think it matters that the changing to black and white doesn't work on windows so I guess I will merge. |
Preprocessing is done (sorta, kinda, good enough).
Input:
Output:
This closes #4 and contains most of the shit needed for #7 .
As discussed before, I need two people to check this pull request. First person can comment approval, second person comments & merges.
Enjoy!!